Messages in this thread | | | Date | Mon, 11 Feb 2008 13:58:34 -0500 | From | Kyle McMartin <> | Subject | Re: [PATCH?][arch/parisc/kernel/pci-dma.c] pcxl_dma_ops.alloc_noncoherent |
| |
On Mon, Feb 11, 2008 at 07:56:10PM +0100, Roel Kluin wrote: > +/* > + * dma_alloc_noncoherent is a fallback for boxes PA7200 and below which > + * cannot allocate coherent memory. > + */ > static void *pa11_dma_alloc_noncoherent(struct device *dev, size_t size, > dma_addr_t *dma_handle, gfp_t flag) > {
Why? This is located below pcxl_dma_ops so its obviously only relevant for pcx.
> @@ -586,6 +590,10 @@ static void pa11_dma_free_noncoherent(struct device *dev, size_t size, > return; > } > > +/* > + * PCXL allocates coherent memory even for dma_alloc_noncoherent() due to the > + * uncached trick for coherent memory. > + */
This isn't correct either.
> struct hppa_dma_ops pcx_dma_ops = { > .dma_supported = pa11_dma_supported, > .alloc_consistent = fail_alloc_consistent, >
| |