Messages in this thread | | | Date | Mon, 11 Feb 2008 09:15:50 -0700 | From | Matthew Wilcox <> | Subject | Re: raw_pci_read in quirk_intel_irqbalance |
| |
On Mon, Feb 11, 2008 at 12:49:54AM -0700, Grant Grundler wrote: > Can you also add a comment which points at the Intel documentation? > > http://download.intel.com/design/chipsets/datashts/30300702.pdf > Page 34 documents 0xf4 register.
I'm told that these URLs are not guaranteed to be stable. And remembering the pain we had when HP decided to relocate all of their documents, I'm really not inclined to embed a link to a URL in the source code.
> And I just doubled checked that the 0xf4 register value is restored later > in the quirk (obvious when you look at the code but not from the patch).
Yep, I checked that too ;-)
> Acked-by: Grant Grundler <grundler@parisc-linux.org>
Thanks.
-- Intel are signing my paycheques ... these opinions are still mine "Bill, look, we understand that you're interested in selling us this operating system, but compare it to ours. We can't possibly take such a retrograde step."
| |