lkml.org 
[lkml]   [2008]   [Feb]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH] [6/8] Account overlapped mappings in end_pfn_map
    From
    Date

    On Mon, 2008-02-11 at 14:27 +0100, Andi Kleen wrote:

    > Ok patch with hungarized variables appended.

    > -static void __meminit
    > +static unsigned long __meminit
    > phys_pmd_update(pud_t *pud, unsigned long address, unsigned long end)
    > {
    > + unsigned long true_end;
    > pmd_t *pmd = pmd_offset(pud, 0);
    > spin_lock(&init_mm.page_table_lock);
    > - phys_pmd_init(pmd, address, end);
    > + true_end = phys_pmd_init(pmd, address, end);
    > spin_unlock(&init_mm.page_table_lock);
    > __flush_tlb_all();
    > + return true_end;
    > }

    Just for the record, Hungarian notation would have it like:

    ulTrueEnd

    http://en.wikipedia.org/wiki/Hungarian_notation

    And the kernel doesn't do that, to wit (from Documentation/CodingStyle):

    Linus Torvalds (against systems Hungarian): Encoding the type of a
    function into the name (so-called Hungarian notation) is brain damaged -
    the compiler knows the types anyway and can check those, and it only
    confuses the programmer.





    \
     
     \ /
      Last update: 2008-02-11 15:19    [W:0.042 / U:0.432 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site