Messages in this thread | | | Date | Sun, 10 Feb 2008 20:34:55 +0100 | From | Ingo Molnar <> | Subject | Re: [git pull] kgdb light, v5 |
| |
* Jan Kiszka <jan.kiszka@web.de> wrote:
> [This still runs fine here, but sharp eyes are always welcome!] > > Cleanup of the way kgdb > - accesses unsafe memory via probe_kernel_* > - converts to/from hex representation > - passes errors due to such accesses around > > At this chance I also fix kgdb_ebin2mem, which was broken /wrt escape > sequence handling.
great! Applied. The kgdb memory accesses look _much_ cleaner now, and it's a significant simplification as well:
2 files changed, 109 insertions(+), 244 deletions(-)
the uaccess.h macros look a bit ugly now (it all got inherited from the existing [and ancient] probe_kernel_address() macro) and because we now touch it materially anyway, we might as well do it right?
Ingo
| |