lkml.org 
[lkml]   [2008]   [Feb]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [git pull] kgdb light, v5

* Jan Kiszka <jan.kiszka@web.de> wrote:

> [This still runs fine here, but sharp eyes are always welcome!]
>
> Cleanup of the way kgdb
> - accesses unsafe memory via probe_kernel_*
> - converts to/from hex representation
> - passes errors due to such accesses around
>
> At this chance I also fix kgdb_ebin2mem, which was broken /wrt escape
> sequence handling.

great! Applied. The kgdb memory accesses look _much_ cleaner now, and
it's a significant simplification as well:

2 files changed, 109 insertions(+), 244 deletions(-)

the uaccess.h macros look a bit ugly now (it all got inherited from the
existing [and ancient] probe_kernel_address() macro) and because we now
touch it materially anyway, we might as well do it right?

Ingo


\
 
 \ /
  Last update: 2008-02-10 20:41    [W:0.076 / U:1.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site