Messages in this thread | | | Date | Sat, 2 Feb 2008 01:03:43 +0100 | From | "Dmitry Adamushko" <> | Subject | Re: [Regression] 2.6.24-git3: Major annoyance during suspend/hibernation on x86-64 (bisected) |
| |
On 02/02/2008, Ingo Molnar <mingo@elte.hu> wrote: > > * Dmitry Adamushko <dmitry.adamushko@gmail.com> wrote: > > > yeah, I was already on a half-way to check it out. > > > > It does fix a problem for me. > > > > Don't forget to take along these 2 fixes from Peter's patch: > > > > - fix break usage in do_each_thread() { } while_each_thread(). > > - fix the hotplug switch stmt, a fall-through case was broken. > > Dmitry, i sent Peter's fix(es) below to Linus. Do you concur that it > fixes all the practical and theoretical problems you could see with the > code too? >
One comment: any argument for waking up the 'watchdog' thread from softlockup_tick() wrt just having schedule_timeout_interruptible(HZ) in watchdog() ? (although, it's not that important).
IMHO, it looks good.
(I'll look again tomorrow when I'm less sleepy :-/)
-- Best regards, Dmitry Adamushko
| |