lkml.org 
[lkml]   [2008]   [Dec]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] watchdog: New library code
On Tue, 9 Dec 2008 17:14:25 +0100
Wim Van Sebroeck <wim@iguana.be> wrote:

> Hi Alan,
>
> The flue changed my weekend :-(. I do however have 2 general questions first:
>
> > - Handles the temperature device
> Why don't we treat the temperature part not as a hwmon?

Because the temperature interface was there first and is part of the
existing kernel to user space API. Now that the device is abstracted I
agree entirely that it should also appear in hwmon and the support
library code can be extended to do this along with multiple watchdogs.
>
> > - It does all the reboot, nowayout and module locking and housekeeping
> Why don't we use the shutdown methods of our platform and other devices instead of the reboot notifier setup?

As and when watchdogs are all platform devices we probably should. Right
now most of them are not and we don't really have a proper 'isa_device'
object yet. I see that as a migration path or an 'aspiration', but having
it in one place will make that easier to achieve after we have the common
API.

Likewise sysfs, classes and multiple watchdogs all want addressing but
that gets a lot easier once everything is using a common framework and a
passed 'struct watchdog' to make multiple instances just work.

Alan


\
 
 \ /
  Last update: 2008-12-09 17:57    [from the cache]
©2003-2011 Jasper Spaans