Messages in this thread | | | Date | Tue, 9 Dec 2008 11:27:45 -0500 | From | Jason Baron <> | Subject | Re: [rfc] [patch] hook tracer to dynamic debug |
| |
On Sat, Dec 06, 2008 at 09:48:40PM -0800, Greg KH wrote: > On Fri, Dec 05, 2008 at 02:39:28PM -0500, Jason Baron wrote: > > hi, > > > > Currently, the dynamic debug framework uses 'printk' for output. Here, > > i've hooked the backend of the dynamic debug framework to the tracing > > framework. This allows the dynamic debug output to be seaprated from the > > system log, and allows for higher performance. > > Is this really an issue most of the time? > > I know logs can get full, but this seems like a bit of an overkill :) > > > I've implemented it as a compile time option, but a user might want to > > be able to toggle b/w 'printk' and the tracer at run-time...other > > ideas? Patch is against the -tip tree... > > It would have to be a run-time option if you want any distro to ever be > able to enable this in their kernels. >
There haven't been any specfic complaints about this, although the all 'on' case does really spew quite a lot into the logs. Using Frederic's suggestion I'm able to implement this with only a few lines of code...so I'll keep it around if we ever need it...
thanks,
-Jason
| |