Messages in this thread Patch in this message | | | Date | Mon, 8 Dec 2008 19:30:43 -0500 | From | Steven Rostedt <> | Subject | Re: [PATCH 11/13] checkpatch: struct file_operations should normally be const |
| |
On Sun, Dec 07, 2008 at 06:30:48PM +0000, Andy Whitcroft wrote: > From: Andy Whitcroft <apw@canonical.com> > > In the general use case struct file_operations should be a const object. > Check for and warn where it is not. As suggested by Steven and Ingo.
Andy,
Thanks for doing this!
Acked-by: Steven Rostedt <rostedt@goodmis.org>
-- Steve
> > Cc: Steven Rostedt <rostedt@goodmis.org> > Cc: Ingo Molnar <mingo@elte.hu> > Signed-off-by: Andy Whitcroft <apw@canonical.com> > --- > scripts/checkpatch.pl | 5 +++++ > 1 files changed, 5 insertions(+), 0 deletions(-) > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl > index c39ce0b..94371f6 100755 > --- a/scripts/checkpatch.pl > +++ b/scripts/checkpatch.pl > @@ -2509,6 +2509,11 @@ sub process { > if ($line =~ /^.\s*__initcall\s*\(/) { > WARN("please use device_initcall() instead of __initcall()\n" . $herecurr); > } > +# check for struct file_operations, ensure they are const. > + if ($line =~ /\bstruct\s+file_operations\b/ && > + $line !~ /\bconst\b/) { > + WARN("struct file_operations should normally be const\n" . $herecurr); > + } > > # use of NR_CPUS is usually wrong > # ignore definitions of NR_CPUS and usage to define arrays as likely right > -- > 1.6.0.4.911.gc990 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ >
| |