lkml.org 
[lkml]   [2008]   [Dec]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [W1] List slaves commands.
On Mon, Dec 08, 2008 at 01:58:48PM -0800, Andrew Morton (akpm@linux-foundation.org) wrote:
> This code performs quite a lot of potentially unaligned acceses.
>
> Is there anything which guarantees that all these accesses are
> well-aligned?
>
> If not, will there be issues with platforms which don't handle
> unaligned accesses as well as x86?
>
> Should this code be using the unaligned access interfaces
> (get_unaligned, put_unaligned, etc. Might be wrong. Keeps changing.
> Harvey Harrison is the guy to ask)?

Every store should be at least 4-bytes aligned because of used headers.
Particular mentioned command is 8-bytes aligned (and all its writes)
as long as others in this patchset (pointer alignment + 40 or 32 bytes
of the headers).

--
Evgeniy Polyakov


\
 
 \ /
  Last update: 2008-12-08 23:53    [W:0.041 / U:0.856 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site