lkml.org 
[lkml]   [2008]   [Dec]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [W1] List slaves commands.
On Fri,  5 Dec 2008 15:41:27 +0300
Evgeniy Polyakov <zbr@ioremap.net> wrote:

> + u64 *data = (void *)(cmd + 1) + cmd->len;
> +
> + *data = rn;

This code performs quite a lot of potentially unaligned acceses.

Is there anything which guarantees that all these accesses are
well-aligned?

If not, will there be issues with platforms which don't handle
unaligned accesses as well as x86?

Should this code be using the unaligned access interfaces
(get_unaligned, put_unaligned, etc. Might be wrong. Keeps changing.
Harvey Harrison is the guy to ask)?



\
 
 \ /
  Last update: 2008-12-08 23:03    [W:0.384 / U:0.272 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site