Messages in this thread | | | Date | Mon, 8 Dec 2008 13:58:48 -0800 | From | Andrew Morton <> | Subject | Re: [W1] List slaves commands. |
| |
On Fri, 5 Dec 2008 15:41:27 +0300 Evgeniy Polyakov <zbr@ioremap.net> wrote:
> + u64 *data = (void *)(cmd + 1) + cmd->len; > + > + *data = rn;
This code performs quite a lot of potentially unaligned acceses.
Is there anything which guarantees that all these accesses are well-aligned?
If not, will there be issues with platforms which don't handle unaligned accesses as well as x86?
Should this code be using the unaligned access interfaces (get_unaligned, put_unaligned, etc. Might be wrong. Keeps changing. Harvey Harrison is the guy to ask)?
| |