Messages in this thread Patch in this message | | | From | Andy Whitcroft <> | Subject | [PATCH 11/13] checkpatch: struct file_operations should normally be const | Date | Sun, 7 Dec 2008 18:30:48 +0000 |
| |
From: Andy Whitcroft <apw@canonical.com>
In the general use case struct file_operations should be a const object. Check for and warn where it is not. As suggested by Steven and Ingo.
Cc: Steven Rostedt <rostedt@goodmis.org> Cc: Ingo Molnar <mingo@elte.hu> Signed-off-by: Andy Whitcroft <apw@canonical.com> --- scripts/checkpatch.pl | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index c39ce0b..94371f6 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -2509,6 +2509,11 @@ sub process { if ($line =~ /^.\s*__initcall\s*\(/) { WARN("please use device_initcall() instead of __initcall()\n" . $herecurr); } +# check for struct file_operations, ensure they are const. + if ($line =~ /\bstruct\s+file_operations\b/ && + $line !~ /\bconst\b/) { + WARN("struct file_operations should normally be const\n" . $herecurr); + } # use of NR_CPUS is usually wrong # ignore definitions of NR_CPUS and usage to define arrays as likely right -- 1.6.0.4.911.gc990
| |