Messages in this thread | | | Date | Sat, 6 Dec 2008 01:02:16 +0000 | From | "Américo Wang" <> | Subject | Re: [Patch] uml: drop const qualifier for kernel_execve() |
| |
On Wed, Dec 3, 2008 at 1:40 PM, Johannes Weiner <hannes@cmpxchg.org> wrote: > On Wed, Dec 03, 2008 at 12:32:02PM +0000, Américo Wang wrote: >> On Wed, Dec 3, 2008 at 1:20 AM, Johannes Weiner <hannes@cmpxchg.org> wrote: >> > On Tue, Dec 02, 2008 at 10:51:09PM +0000, Américo Wang wrote: >> >> UML implementation of kernel_execve() should not have const qualifier, >> >> because it will finally call do_execve() which doesn't have. >> > >> > And you made sure that do_execve() is correctly annotated? >> > >> >> Yes, I checked that. > > Good. Then please fix up do_execve() or let the warning stand out as > a reminder.
?? Confused...
do_execve() is OK, we don't need to fix it.
Thanks.
| |