Messages in this thread | | | Date | Fri, 5 Dec 2008 14:52:53 +0100 | From | Ingo Molnar <> | Subject | Re: [patch] export percpu cpuacct cgroup stats |
| |
* Li Zefan <lizf@cn.fujitsu.com> wrote:
> Ken Chen wrote: > > On Thu, Dec 4, 2008 at 11:54 PM, Li Zefan <lizf@cn.fujitsu.com> wrote: > >>> + seq_printf(m, "%llu ", percpu); > >> Should be: > >> + seq_printf(m, "%llu ", (unsigned long long)percpu); > >> > >> Otherwsise: > >> kernel/sched.c: In function 'cpuacct_percpu_seq_read': > >> kernel/sched.c:9359: warning: format '%llu' expects type 'long long unsigned int', > >> but argument 3 has type 'u64' > > > > huh, I was just wondering about the type case in cgroup_read_u64() > > when I was looking at it earlier. That explains it. Diff patch > > attached. > > > > Reviewed-by: Li Zefan <lizf@cn.fujitsu.com>
Could someone please send the final patch with a final changelog, with all fixlets and tags in place please?
Thanks,
Ingo
| |