lkml.org 
[lkml]   [2008]   [Dec]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/3] tracing/ftrace: don't insert TRACE_PRINT during selftests

* Frederic Weisbecker <fweisbec@gmail.com> wrote:

> Impact: fix tracer selfstests false results
>
> After setting a ftrace_printk somewhere in th kernel, I saw the
> Function tracer selftest failing.
>
> When a selftest occurs, the ring buffer is lurked to see if
> some entries were inserted. But concurrent insertion such as
> ftrace_printk could occured at the same time and could give
> false positive or negative results.
>
> This patch prevent prevent from TRACE_PRINT entries insertion
> during selftests.
>
> Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
> ---
> kernel/trace/trace.c | 13 ++++++++++++-
> 1 files changed, 12 insertions(+), 1 deletions(-)

applied to tip/tracing/ftrace, thanks.

I suspect you'll also fix the things Steve pointed out?

Ingo


\
 
 \ /
  Last update: 2008-12-05 14:51    [W:0.088 / U:0.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site