Messages in this thread | | | Date | Thu, 4 Dec 2008 09:46:28 -0500 (EST) | From | Steven Rostedt <> | Subject | Re: [PATCH 3/3] ftrace: add ability to only trace swapper tasks |
| |
On Thu, 4 Dec 2008, Eric W. Biederman wrote:
> Ingo Molnar <mingo@elte.hu> writes: > > > * Andrew Morton <akpm@linux-foundation.org> wrote: > > > >> > Signed-off-by: Steven Rostedt <srostedt@redhat.com> > >> > >> What does this patch actually do? Is swapper currently excluded from > >> tracing for undisclosed reasons and this patch permits it to be traced? > >> If so, why was swapper thus excluded? Or am I totally off track? > > > >> > +static struct pid * const ftrace_swapper_pid = (struct pid *)1; > >> > >> eh? > > > > all side-effects of getting rid of the integer based PID namespace and > > replacing them with struct pid pointers. > > Thanks for asking Andrew it looks like an unnecessary side effect.
Well, it was necessary without hacking fork.c ;-)
-- Steve
| |