lkml.org 
[lkml]   [2008]   [Dec]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: BUG? "Call fasync() functions without the BKL" is racy
    On 12/03, Jonathan Corbet wrote:
    >
    > On Wed, 03 Dec 2008 22:21:02 +0100
    > Andi Kleen <ak@linux.intel.com> wrote:
    >
    > > > Serioulsy, I think the best (partial, yes) fix for now is to restore
    > > > lock_kernel() in setfl() and change ioctl_fioxxx() accordingly.
    > > > At least this protect us from tty too.
    > >
    > > For 2.6.28 I agree.
    >
    > OK, what do you all think of the following? It returns fcntl.c to its
    > previous state, and adds locking in fs/ioctl.c. It's worth noting that
    > ioctl_fioasync() has always been racy in exactly the same way.

    Yes, I agree with you and Andi, imho this is what we need for 2.6.28.

    Thanks Jonathan!

    Oleg.



    \
     
     \ /
      Last update: 2008-12-04 15:39    [W:0.027 / U:31.040 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site