lkml.org 
[lkml]   [2008]   [Dec]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 01/15] ACPI: create kernel/acpi/
    On Wed, Dec 31, 2008 at 03:21:08PM +0100, Andi Kleen wrote:
    > Sam Ravnborg <sam@ravnborg.org> writes:
    > > Why is ACPI_CFLAGS exported?
    > >> +ACPI_CFLAGS := -Os
    > >> +
    > >> +ifdef CONFIG_ACPI_DEBUG
    > >> + ACPI_CFLAGS += -DACPI_DEBUG_OUTPUT
    > >> +endif
    > >> +
    > >> +EXTRA_CFLAGS += $(ACPI_CFLAGS)
    > > A better way:
    > >
    > > ccflags-$(CONFIG_ACPI_DEBUG) := -DACPI_DEBUG_OUTPUT
    >
    > Surely s/:=/+=/ ?

    Only if ccflags-y is assigned earlier in the same file
    otherwise it does not matter.

    Sam


    \
     
     \ /
      Last update: 2008-12-31 16:35    [W:0.019 / U:2.024 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site