lkml.org 
[lkml]   [2008]   [Dec]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 01/14] kmemleak: Add the base support
* Andrew Morton <akpm@linux-foundation.org> wrote:

> > +/*
> > + * Stop the automatic memory scanning thread. This function must be called
> > + * with the kmemleak_mutex held.
> > + */
> > +void stop_scan_thread(void)
> > +{
> > + if (scan_thread) {
> > + kthread_stop(scan_thread);
> > + scan_thread = NULL;
> > + }
> > +}
>
> so... why do we need a kernel thread?
>
> We could have (for the sake of argument) a sys_kmemleak_scan() which
> does a single scan then returns. Or something like that. That way,
> userspace directly gets to set the scanning frequency, thread priority,
> etc.

thread priority of a kernel thread can be set anyway. Kernel threads tend
to be better for such simple things because we can control all aspects,
start them automatically so that test setups catch it (without needing any
userspace component), etc.

Ingo


\
 
 \ /
  Last update: 2008-12-30 08:41    [W:0.132 / U:1.196 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site