lkml.org 
[lkml]   [2008]   [Dec]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/2] module.c: fix module loading failure of large modules (take 2)
    Kyle McMartin wrote:
    > Ugh, I fail at typing, resending for rusty's benefit.
    >
    > On Tue, Dec 30, 2008 at 01:07:24PM -0500, Kyle McMartin wrote:
    >> [Adding rusty to CC]
    >>
    >> On Mon, Dec 29, 2008 at 09:43:12PM +0100, Helge Deller wrote:
    >>> +unsigned long module_additional_section_size(struct module *mod,
    >>> + unsigned int section);
    >>> +
    >> I think this would be more palatable as
    >>
    >> #ifdef HAVE_MODULE_SECTION_STUBS
    >> unsigned long module_additional_section_size(struct module *mod,
    >> unsigned int section);
    >> #else
    >> static inline unsigned long module_additional_section_size(struct module *mod,
    >> unsigned int section)
    >> {
    >> return 0;
    >> }
    >> #endif
    >>
    >> and removing the conditional in kernel/module.c, possibly the symbol
    >> should be "arch_module_a..." just to make it clear to anyone reading.
    >>
    >> Anyway, it's up to rusty.
    >>
    >> Rusty, we'd like to get this patch in, so I can merge the dependent
    >> parisc-specific patch.

    Rusty, I think I've a cleaner patch for that and will send it soon...

    Helge


    \
     
     \ /
      Last update: 2008-12-30 19:21    [W:4.153 / U:0.696 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site