lkml.org 
[lkml]   [2008]   [Dec]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    SubjectRe: Yet more ARM breakage in linux-next
    Date
    On Thursday 04 December 2008 12:03:57 Mike Frysinger wrote:
    > On Wed, Dec 3, 2008 at 18:22, Rusty Russell wrote:
    > > On Thursday 04 December 2008 07:11:09 Andrew Morton wrote:
    > >> On Wed, 3 Dec 2008 19:29:05 +0000
    > >>
    > >> Russell King <rmk+lkml@arm.linux.org.uk> wrote:
    > >> > This seems to be causing lots of ARM breakage:
    > >> >
    > >> > lib/find_next_bit.c:183: error: implicit declaration of function
    > >> > '__fls'
    > >> >
    > >> > Whoever's responsible,
    > >>
    > >> git-blame?
    > >
    > > It's me. Turns out sparc, avr32 and arm all don't define __fls in their
    > > asm/bitops.h, and I'm the first one to use it in generic code.
    >
    > the Blackfin port also does not ... you going to post a change for
    > that since the build breaks for Blackfin atm too ?
    > -mike

    Sure, why not join the party!

    (Hmm, maybe I should change that list to a shorter list of archs which
    *do* define __fls?)

    blackfin: define __fls

    Like fls, but can't be handed 0 and returns the bit number.

    (I broke this arch in linux-next by using __fls in generic code).

    Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

    diff --git a/arch/blackfin/include/asm/bitops.h b/arch/blackfin/include/asm/bitops.h
    --- a/arch/blackfin/include/asm/bitops.h
    +++ b/arch/blackfin/include/asm/bitops.h
    @@ -213,6 +213,7 @@ static __inline__ int __test_bit(int nr,
    #endif /* __KERNEL__ */

    #include <asm-generic/bitops/fls.h>
    +#include <asm-generic/bitops/__fls.h>
    #include <asm-generic/bitops/fls64.h>

    #endif /* _BLACKFIN_BITOPS_H */


    \
     
     \ /
      Last update: 2008-12-04 03:19    [W:0.041 / U:0.144 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site