Messages in this thread | | | Date | Thu, 4 Dec 2008 11:14:52 +1100 | From | Nick Andrew <> | Subject | Re: About git-bisect (defconfigs) |
| |
On Wed, Dec 03, 2008 at 09:50:51AM -0800, Randy Dunlap wrote: > 2. There are several security-related config items that default to =y but the > kconfig help says: If unsure, say N here. Like: > > > CONFIG_NETLABEL=y > CONFIG_NETWORK_SECMARK=y > CONFIG_KEYS=y > CONFIG_SECURITY=y > CONFIG_SECURITY_NETWORK=y > CONFIG_SECURITY_SELINUX=y > > Maybe I just don't understand the current meaning/usage of defconfig. eh?
A consistent approach to the Kconfig hints would help. To me, "If unsure, say N" implies that turning off the feature won't break the kernel nor be anything particularly important. The Kconfig hints should follow the defaults (or else why default to 'y'?) for common architectures.
Perhaps menuconfig can generate the "If unsure" message itself from the architecture defaults? That will ensure consistency.
Nick.
| |