Messages in this thread | | | Date | Wed, 3 Dec 2008 15:12:03 -0500 | From | Jason Baron <> | Subject | Re: [PATCH] DEBUG_KOBJECT vs. DYNAMIC_PRINTK_DEBUG |
| |
On Tue, Dec 02, 2008 at 02:52:51PM +0100, Cornelia Huck wrote: > DEBUG_KOBJECT has no effect when DYNAMIC_PRINTK_DEBUG is set > (and you can get the messages via that feature), so let's make > it depend on !DYNAMIC_PRINTK_DEBUG. >
indeed. you raise the more general question of what do if both 'DEBUG' and 'CONFIG_DYNAMIC_PRINTK_DEBUG' are set for a file? I think that in general the 'DEBUG' should take precedence, as you point out. However, I think we should fix this by reshuffling the logic in include/linux/kernel.h by doing:
if (DEBUG) #define pr_debug printk elseif (CONFIG_DYNAMIC_PRINTK_DEBUG) #define pr_debug dynamic_pr_debug() else #define pr_debug if (0) blah: endif
make sense? what do you think?
thanks,
-Jason
| |