Messages in this thread Patch in this message | | | From | "Prakash, Sathya" <> | Date | Tue, 30 Dec 2008 09:50:29 +0530 | Subject | RE: [PATCH 3/7] drivers/message/fusion: Move a dereference below a NULL test |
| |
ACK.
-----Original Message----- From: Julia Lawall [mailto:julia@diku.dk] Sent: Friday, December 26, 2008 12:58 PM To: Moore, Eric; Support, Software; DL-MPT Fusion Linux; linux-scsi@vger.kernel.org; linux-kernel@vger.kernel.org; kernel-janitors@vger.kernel.org Subject: [PATCH 3/7] drivers/message/fusion: Move a dereference below a NULL test
From: Julia Lawall <julia@diku.dk>
If the NULL test is necessary, then the dereference should be moved below the NULL test.
The semantic patch that makes this change is as follows: (http://www.emn.fr/x-info/coccinelle/).
// <smpl> @disable is_null@ identifier f; expression E; identifier fld; statement S; @@
+ if (E == NULL) S f(...,E->fld,...); - if (E == NULL) S
@@ identifier f; expression E; identifier fld; statement S; @@
+ if (!E) S f(...,E->fld,...); - if (!E) S // </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
--- drivers/message/fusion/mptctl.c | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/message/fusion/mptctl.c b/drivers/message/fusion/mptctl.c index b89f476..c638171 100644 --- a/drivers/message/fusion/mptctl.c +++ b/drivers/message/fusion/mptctl.c @@ -308,10 +308,11 @@ static void mptctl_timeout_expired (MPT_IOCTL *ioctl) { int rc = 1;
- dctlprintk(ioctl->ioc, printk(MYIOC_s_DEBUG_FMT ": Timeout Expired! Host %d\n", - ioctl->ioc->name, ioctl->ioc->id)); if (ioctl == NULL) return; + dctlprintk(ioctl->ioc, + printk(MYIOC_s_DEBUG_FMT ": Timeout Expired! Host %d\n", + ioctl->ioc->name, ioctl->ioc->id));
ioctl->wait_done = 0; if (ioctl->reset & MPTCTL_RESET_OK)
| |