Messages in this thread | | | Date | Mon, 29 Dec 2008 12:36:41 -0800 | From | "H. Peter Anvin" <> | Subject | Re: [PATCH] kbuild: auto-convert size types in userspace headers |
| |
Mike Frysinger wrote: > On Monday 29 December 2008 09:03:56 Sam Ravnborg wrote: >> On Mon, Dec 29, 2008 at 06:12:33AM -0500, Mike Frysinger wrote: >>> Rather than constantly fixing up size type breakage in userspace headers, >>> auto convert the types u_intXX_t, uintXX_t, intXX_t, uXX, and sXX to the >>> appropriate __uXX or __sXX type. >> Is this the right thing to do? >> uintXX_t belongs to a namespace that the kernel should not use. > > some headers are shared between projects and so use the uintXX_t form, so i'm > not sure outright banning it is a nice answer for them
Arguably, the right answer is the opposite... the Linux u* and s* forms feel much more like nonstandard legacy code to me. They have the advantage of brevity, however.
-hpa
-- H. Peter Anvin, Intel Open Source Technology Center I work for Intel. I don't speak on their behalf.
| |