[lkml]   [2008]   [Dec]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    Patch in this message
    Subject[PATCH -stable] fix USB_STORAGE_CYPRESS_ATACB

    64a87b244b9297667ca80264aab849a36f494884 broke USB_STORAGE_CYPRESS_ATACB

    Could it be applied to kernel-stable ?


    64a87b244b9297667ca80264aab849a36f494884 commit change the scsi_eh_prep_cmnd logic by making it clear the ->cmnd buffer.

    But the sat to cypress atacb translation supposed the ->cmnd buffer wasn't modified.

    This patch makes it set the ->cmnd buffer after scsi_eh_prep_cmnd call.

    Signed-off-by: Matthieu CASTET <>
    diff --git a/drivers/usb/storage/cypress_atacb.c b/drivers/usb/storage/cypress_atacb.c
    index 898e67d..526c9aa 100644
    --- a/drivers/usb/storage/cypress_atacb.c
    +++ b/drivers/usb/storage/cypress_atacb.c
    @@ -143,6 +143,8 @@ void cypress_atacb_passthrough(struct scsi_cmnd *srb, struct us_data *us)
    * the read taskfile bit, for not executing atacb command,
    * but reading register selected in srb->cmnd[4]
    + srb->cmd_len = 16;
    + memcpy(srb->cmnd, ses.cmnd, srb->cmd_len);
    srb->cmnd[2] = 1;

    usb_stor_transparent_scsi_command(srb, us);
     \ /
      Last update: 2008-12-29 19:19    [W:0.018 / U:36.388 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site