lkml.org 
[lkml]   [2008]   [Dec]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 10/13] drivers/usb/gadget: use USB API functions rather than constants
Date
On Monday 29 December 2008, Julia Lawall wrote:
> > > +#include <linux/usb.h>
> > >  #include <linux/usb/ch9.h>
> > >  #include <linux/usb/gadget.h>
> >
> > While there's nothing wrong with this part of the patch,

Not so; there *is* something wrong in requiring the
peripheral side support to use a host side header.


> > it hardly
> > seems necessary.  Was there any reason for including it?
>
> The new functions are defined in usb.h. I have added the include in
> this file and in the file epautoconf.c that this file includes.  If it is
> removed from both, then the code does not compile (after make
> allyesconfig):

Those functions were supposed to go into <linux/usb/ch9.h>, as
I recall, since they weren't specific to the host side stack.

Having them added to the wrong file is surely part of why
they've only been used by host side drivers. :)

- Dave



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2008-12-29 19:17    [W:0.042 / U:0.352 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site