lkml.org 
[lkml]   [2008]   [Dec]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] parisc: fix module loading failure of large modules
John David Anglin wrote:
> Hi Helge,
>
>> With this patch we now instead append individual PLT stub entries
>> directly at the end of the code sections where the stubs are actually
>> called. This reduces the distance between the PCREL location and the
>> stub entry so that the relocations can be fulfilled.
>
> GCC for PA-RISC assumes that the stubs will be placed before the code
> section. This is what HP-UX does. It's also not possible to compute
> the distance to the end of a function in GCC due to the way branch
> shortening is done. If the distance to the start of the code section
> is too large, GCC outputs a long call.

Interesting. I didn't knew that.

> If you can insert them before the code section where the stubs are
> called, this will minimize the chance that a pc-relative call will
> not reach its stub.

Yes, good idea.
I'll change that and send an updated patch.

> Great patch!

Thanks!

Helge


\
 
 \ /
  Last update: 2008-12-29 18:59    [W:0.054 / U:0.228 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site