Messages in this thread | | | Date | Mon, 29 Dec 2008 09:44:05 -0800 | From | "H. Peter Anvin" <> | Subject | Re: [PATCH] x86 byteorder.h: use __asm__/__inline__ for userspace |
| |
Mike Frysinger wrote: > On Saturday 27 December 2008 16:09:52 H. Peter Anvin wrote: >> Mike Frysinger wrote: >>> ... >>> #ifdef __KERNEL__ >>> # define kernel_flock flock >>> #endif >>> struct kernel_flock { >>> ... >> FWIW, a long time ago I proposed the __kabi_ prefix for these things; I >> think it is a good thing to make userspace-visible structures stand out >> even in the kernel code itself. >> >> As such, I would suggest *not* adding the #define at all. > > the convention based on linux/types.h seems to be to use __kernel_ as the > prefix, but it doesnt matter to me whether it's __kabi_ or __kernel_. i'll > start doing the latter though in the hopes it'll be less scary ;).
Agreed, the actual prefix doesn't matter. I suggested __kabi to be more explicit about the fact that it is an exported ABI, but I think the main thing is to not #define it out.
-hpa
-- H. Peter Anvin, Intel Open Source Technology Center I work for Intel. I don't speak on their behalf.
| |