lkml.org 
[lkml]   [2008]   [Dec]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 3/3] kmemtrace: Use tracepoints instead of markers.
From
Date
Hi Eduard,

On Mon, 2008-12-29 at 03:40 +0200, Eduard - Gabriel Munteanu wrote:
> diff --git a/mm/slab.c b/mm/slab.c
> index 1fcb32b..74d405d 100644
> --- a/mm/slab.c
> +++ b/mm/slab.c
> @@ -3624,8 +3624,9 @@ void *kmem_cache_alloc(struct kmem_cache *cachep, gfp_t flags)
> {
> void *ret = __cache_alloc(cachep, flags, __builtin_return_address(0));
>
> - kmemtrace_mark_alloc(KMEMTRACE_TYPE_CACHE, _RET_IP_, ret,
> - obj_size(cachep), cachep->buffer_size, flags);
> + trace_kmemtrace_alloc(KMEMTRACE_TYPE_CACHE, _RET_IP_, ret,
> + obj_size(cachep), cachep->buffer_size,
> + flags, -1);

One minor nit: I'd prefer we call these trace_kmem_cache_alloc(),
trace_kmalloc(), and so on. The trace_kmemtrace prefix doesn't really
make much sense to me.



\
 
 \ /
  Last update: 2008-12-29 14:47    [W:0.100 / U:3.476 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site