lkml.org 
[lkml]   [2008]   [Dec]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] move arch/x86/pci/pci.h to arch/x86/include/asm/pci_x86.h

* Ingo Molnar <mingo@elte.hu> wrote:

>
> * Sam Ravnborg <sam@ravnborg.org> wrote:
>
> > >
> > > btw., you missed to update a couple of places - pci/pci.h was used outside
> > > of arch/x86 as well. Updated patch below.
> > >
> > > Ingo
> > >
> > > ---------------->
> > > >From 54a090abe7cb85c724305124f57d2570b7e9adf1 Mon Sep 17 00:00:00 2001
> > > From: Jaswinder Singh Rajput <jaswinder@infradead.org>
> > > Date: Sat, 27 Dec 2008 18:32:28 +0530
> > > Subject: [PATCH] x86, pci: move arch/x86/pci/pci.h to arch/x86/include/asm/pci_x86.h
> > >
> > > Impact: cleanup
> > >
> > > Now that arch/x86/pci/pci.h is used in a number of other places as well,
> > > move the lowlevel x86 pci definitions into the architecture include files.
> > > (not to be confused with the existing arch/x86/include/asm/pci.h file,
> > > which provides public details about x86 PCI)
> > >
> > > Tested on: X86_32_UP, X86_32_SMP and X86_64_SMP
> > >
> > > Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com>
> > > Signed-off-by: Ingo Molnar <mingo@elte.hu>
> > > ---
> > > arch/x86/include/asm/pci_x86.h | 165 ++++++++++++++++++++++++++++++++++++
> > > arch/x86/kernel/mmconf-fam10h_64.c | 3 +-
> > > arch/x86/kernel/reboot.c | 3 +-
> > > arch/x86/pci/acpi.c | 2 +-
> > > arch/x86/pci/amd_bus.c | 2 +-
> > > arch/x86/pci/common.c | 3 +-
> > > arch/x86/pci/direct.c | 2 +-
> > > arch/x86/pci/early.c | 2 +-
> > > arch/x86/pci/fixup.c | 3 +-
> > > arch/x86/pci/i386.c | 2 +-
> > > arch/x86/pci/init.c | 2 +-
> > > arch/x86/pci/irq.c | 3 +-
> > > arch/x86/pci/legacy.c | 2 +-
> > > arch/x86/pci/mmconfig-shared.c | 3 +-
> > > arch/x86/pci/mmconfig_32.c | 2 +-
> > > arch/x86/pci/mmconfig_64.c | 3 +-
> > > arch/x86/pci/numaq_32.c | 2 +-
> > > arch/x86/pci/olpc.c | 2 +-
> > > arch/x86/pci/pcbios.c | 5 +-
> > > arch/x86/pci/pci.h | 162 -----------------------------------
> > > arch/x86/pci/visws.c | 3 +-
> > > drivers/pci/hotplug/cpqphp_core.c | 2 +-
> > > drivers/pci/hotplug/cpqphp_pci.c | 2 +-
> > > drivers/pci/hotplug/ibmphp_core.c | 2 +-
> > > 24 files changed, 188 insertions(+), 194 deletions(-)
> >
> > You should teach your script to use:
> > git format-patch -M -B -C
> >
> > With -M -B -C you get a much better picture of what happens when you
> > rename files like in this patch (and copy them).
>
> you mean:
>
> git format-patch --stdout -1 -M -B -C <sha1>

also, this does not result in a patch that will be applied properly by the
usual patch-tools that people use when they pick up patches from email. So
i'll just keep my old script ;-)

Ingo


\
 
 \ /
  Last update: 2008-12-29 14:05    [W:0.057 / U:0.408 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site