Messages in this thread | | | Date | Sun, 28 Dec 2008 21:34:54 +0900 | Subject | Re: [PATCH 0 of 9] swiotlb: use phys_addr_t for pages | From | FUJITA Tomonori <> |
| |
On Sun, 28 Dec 2008 12:56:21 +0100 Ingo Molnar <mingo@elte.hu> wrote:
> > * FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp> wrote: > > > You brought up a different topic, DMA bouncing implementations > > unification. DMA bouncing implementations unification is a very nice > > cleanup. But it's not related with Becky's patch to break IA64 build at > > all. > > All i'm saying is that obviously neither Jeremy's nor Becky's patches were > created in a vacuum, and had it not been for the need and desire to extend > swiotlb we'd not have seen Becky's 9/9 cleanup patch either.
As I wrote, Becky's 9/9 cleanup path is not about swiotlb highmem extention. We had known about the need to clean up the dma mapping operation ugliness. But we has ignored it and added workarounds again and again. We haven't seen something like his 9/9 because we added workarounds in architecture-specific code.
Anyway, his 9/9 patch is wrong if we want to fix the root cause. If we don't fix the root cause, the lots of changes of his 9/9 patch don't make sense. Probably, it would better to add some workarounds in architecture-specific code (POWERPC in this case) as we have done in the past.
Ok, I'll try to fix the root cause. We need lots of changes to IA64 especially. Hopefully, I can get Tony's ACK on these changes.
| |