lkml.org 
[lkml]   [2008]   [Dec]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86: reboot.c declare port_cf9_safe before they get used

* Jaswinder Singh <jaswinder@infradead.org> wrote:

> Impact: cleanup, avoid sparse warning
>
> Include "../pci/pci.h" for port_cf9_safe
>
> Fixes this sparse warning:
> arch/x86/kernel/reboot.c:43:6: warning: symbol 'port_cf9_safe' was not declared. Should it be static?
>
> Signed-off-by: Jaswinder Singh <jaswinder@infradead.org>
> ---
> arch/x86/kernel/reboot.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)

applied to tip/x86/cleanups, thanks!

btw., this is ugly now:

> --- a/arch/x86/kernel/reboot.c
> +++ b/arch/x86/kernel/reboot.c
> @@ -22,6 +22,7 @@
> #endif
>
> #include <mach_ipi.h>
> +#include "../pci/pci.h"

could you send another patch that moves arch/x86/pci/pci.h to
arch/x86/include/asm/pci_x86.h (and update all the pci.h include sites)?

Ingo


\
 
 \ /
  Last update: 2008-12-27 11:35    [from the cache]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and my Meterkast|Read the blog