lkml.org 
[lkml]   [2008]   [Dec]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86_64: Eliminate atleast 10684 sparse warnings

* Andrew Morton <akpm@linux-foundation.org> wrote:

> On Sat, 27 Dec 2008 15:21:36 +0530 Jaswinder Singh Rajput <jaswinder@infradead.org> wrote:
>
> > #ifdef CONFIG_ILLEGAL_POINTER_VALUE
> > -# define POISON_POINTER_DELTA CONFIG_ILLEGAL_POINTER_VALUE
> > +# define POISON_POINTER_DELTA _AC(CONFIG_ILLEGAL_POINTER_VALUE, UL)
> > #else
> > # define POISON_POINTER_DELTA 0
> > #endif
>
> So now
>
> commit 948f984df52511bb0efa5c026813b0c34de43aa0
> Author: Avi Kivity <avi@qumranet.com>
> AuthorDate: Tue May 20 14:39:25 2008 +0300
> Commit: Ingo Molnar <mingo@elte.hu>
> CommitDate: Tue May 20 13:42:31 2008 +0200
>
> core, x86: make LIST_POISON less deadly
>
> gets splattered across three commits (at least). Sigh.

Can rebase, although that would hide the (deserved) credit that
Jaswinder's patch deserves. And it does not appear to be a must-rebase
example to me - it's not like one does sparse builds during bisection.

> (how come that patch is 7 moonths old and still unmerged, btw?)

Linus had reservations about the first version (which got fixed but which
prevented it from going upstream in the first cycle) - and it's not an
exactly critical change and other stuff interfered. All our previous merge
windows were fully filled ;)

Ingo


\
 
 \ /
  Last update: 2008-12-27 11:23    [from the cache]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and my Meterkast|Read the blog