Messages in this thread | | | Date | Sun, 28 Dec 2008 00:43:26 +0000 (GMT) | From | Hugh Dickins <> | Subject | Re: linux-next: parsing mem=700M broken |
| |
On Sat, 27 Dec 2008, Rusty Russell wrote: > > On Thursday 25 December 2008 01:14:35 Hugh Dickins wrote: > > But (of course: it's a patch to arch/x86) doesn't help at all on > > ppc64; and I presume other architectures also remain broken... > > Confirmed ppc64. But it's broken in a *different* way. > > Whereas most archs called parse_early_param from setup_arch, powerpc > does it before start_kernel. So instead of moving parsing earlier, > my patch actually moved it later for powerpc. > > Too late, for mem=. > > Rather than try to untangle the powerpc boot process (most archs would > do most of this in setup_arch), I think I have to expose the parser > again so they can call it: > > commit 25bf48b74b9fb23b347d00656b604f9e55c72183 > Author: Rusty Russell <rusty@rustcorp.com.au> > Date: Sat Dec 27 23:40:37 2008 +1030 > > Fix powerpc (tested on ppc64) command line handling. > Powerpc used to call parse_early_param() really early; the change made > it too late. Put it back.
I'll make no pretence of reviewing any of this, but this has indeed got mem= back working for me on a 2.6.28-rc9-mm1 - thanks!
I have to wonder if all this comes too late in the cycle for 2.6.29: changing the early param handling of all the arches is difficult, and apparently hasn't been much tested in the short time that it's been out there in linux-next. But of course, not for me to decide.
Hugh
| |