Messages in this thread | | | Date | Thu, 25 Dec 2008 23:43:45 +0900 | From | "KOSAKI Motohiro" <> | Subject | Re: [PATCH for -tip] irq: for_each_irq_desc() makes simplify |
| |
> | "if (!desc) " mean this irqno don't have irq description. > | so I think this name imply mean skipping no irq desctiption element. > | > | Actually, on CONFIG_SPARSEIRQ, desc is filled in dynamically after booting. > | then "defined" is a bit misleading word. > | > > So if I would need to iterate over all descriptors including empty > I need to type all this long for(;;) form again?
We already have for_each_irq_nr() for this purpose ;-)
> For me for_each_irq_desc > implies to iterate over each irq_desc allocated regardles of internal > descriptor data. For example in list_struct we have a special test if > entry is empty or not. So I think hiding details is not that good (and > that is why I was asking for more descriptive macro name). BUT if it > really supposed to behave like that then I don't object :)
| |