Messages in this thread | | | From | Mike Frysinger <> | Subject | Re: [PATCH] sh: maple: Robust checking for errors on maple keyboard initialisation | Date | Wed, 24 Dec 2008 11:59:13 -0500 |
| |
On Saturday 20 December 2008 13:25:27 Adrian McMenamin wrote: > - maple_set_drvdata(mdev, NULL); > - return error; > +fail: > + return -error;
same comment as for the joystick driver ... it's weird and i'm pretty sure incorrect due to other functions setting error as well as this driver. -mike [unhandled content-type:application/pgp-signature] | |