Messages in this thread | | | Date | Tue, 23 Dec 2008 16:22:23 +0100 | From | Johannes Weiner <> | Subject | Re: [PATCH] failslab for SLUB |
| |
On Tue, Dec 23, 2008 at 04:44:26PM +0200, Pekka Enberg wrote: > Hi Hannes, > > On Tue, 2008-12-23 at 15:43 +0100, Johannes Weiner wrote: > > > static inline void *____cache_alloc(struct kmem_cache *cachep, > > gfp_t flags) > > > { > > > void *objp; > > > @@ -3381,7 +3316,7 @@ __cache_alloc_node(struct kmem_cache *cachep, gfp_t flags, int nodeid, > > > unsigned long save_flags; > > > void *ptr; > > > > > > - if (should_failslab(cachep, flags)) > > > + if (slab_should_failslab(cachep, flags)) > > > > should_failslab()? > > No, look at what slab_should_failslab() does. We need to exclude > cache_cache in SLAB but not in SLUB.
Ah, crap. I missed that small '+' and thought it had been dropped.
Sorry, Pekka.
Hannes
| |