Messages in this thread | | | Date | Wed, 24 Dec 2008 07:37:48 +0900 | From | "Akinobu Mita" <> | Subject | Re: [PATCH] ext4: annotate unhandled kmem_cache_alloc() error |
| |
> BUG_ON is good for devel things, but for stable stuff it's better to let > somebody know an error occured rather than panic'ing the box. The proper > solution would be to do > > if (!new_entry) > return -ENOMEM; > > or if there is some out: label set ret to -ENOMEM and goto out, whatever is > appropriate in the context. Thanks,
I don't understand the code around here well. But I think it is not that simple.
The "new_entry" is needed to free blocks. If it just returns error, it leaks something.
| |