Messages in this thread | | | Date | Tue, 23 Dec 2008 13:59:48 -0800 | From | "Paul E. McKenney" <> | Subject | Re: [PATCH -tip] Switch arm defconfig files from CONFIG_CLASSIC_RCU to CONFIG_TREE_RCU. |
| |
On Tue, Dec 23, 2008 at 03:25:42PM +0100, Ingo Molnar wrote: > > * paulmck@linux.vnet.ibm.com <paulmck@linux.vnet.ibm.com> wrote: > > > From: Paul E. McKenney <paulmck@linux.vnet.ibm.com> > > > > Only for testing in -tip and -next, not yet for inclusion into mainline. > > > > Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com> > > --- > > arch/arm/configs/afeb9260_defconfig | 2 +- > > arch/arm/configs/am200epdkit_defconfig | 2 +- > > arch/arm/configs/cm_x300_defconfig | 2 +- > > arch/arm/configs/corgi_defconfig | 2 +- > > arch/arm/configs/csb637_defconfig | 2 +- > > arch/arm/configs/eseries_pxa_defconfig | 2 +- > > arch/arm/configs/ezx_defconfig | 2 +- > > arch/arm/configs/imx27ads_defconfig | 2 +- > > arch/arm/configs/jornada720_defconfig | 2 +- > > arch/arm/configs/kirkwood_defconfig | 2 +- > > arch/arm/configs/loki_defconfig | 2 +- > > arch/arm/configs/magician_defconfig | 2 +- > > arch/arm/configs/mv78xx0_defconfig | 2 +- > > arch/arm/configs/mx31ads_defconfig | 2 +- > > arch/arm/configs/mx31litekit_defconfig | 2 +- > > arch/arm/configs/omap3_beagle_defconfig | 2 +- > > arch/arm/configs/omap_h2_1610_defconfig | 2 +- > > arch/arm/configs/omap_ldp_defconfig | 2 +- > > arch/arm/configs/orion5x_defconfig | 2 +- > > arch/arm/configs/overo_defconfig | 2 +- > > arch/arm/configs/palmz72_defconfig | 2 +- > > arch/arm/configs/pcm037_defconfig | 2 +- > > arch/arm/configs/pcm038_defconfig | 2 +- > > arch/arm/configs/s3c2410_defconfig | 2 +- > > arch/arm/configs/spitz_defconfig | 2 +- > > arch/arm/configs/tct_hammer_defconfig | 2 +- > > arch/arm/configs/viper_defconfig | 2 +- > > arch/arm/configs/xm_x2xx_defconfig | 2 +- > > 28 files changed, 28 insertions(+), 28 deletions(-) > > ouch! > > There's a much more shrewd method to achieve the same, via 2 lines total > patch: > > Change the name of CONFIG_CLASSIC_RCU to something else such as > CONFIG_FLAT_RCU. That does all the magic and more: all configs will > default to tree-rcu - not just defconfigs! Agreed?
Good point!
> [ I think the gene of laziness is probably more developed in my genome > than in yours. It is a very useful trait ;-) ]
Lazy or not, your approach is much better than what I was doing. ;-)
Two patches in subsequent emails: the first gets rid of a duplicate RCU_CPU_STALL_DETECTOR config declaration (noticed in this exercise -- one each from the CLASSIC_RCU and TREE_RCU stall detectors), and the second changes the default to TREE_RCU as you suggest.
Thanx, Paul
| |