lkml.org 
[lkml]   [2008]   [Dec]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v7 4/8] sched: nominate preferred wakeup cpu
* Vaidyanathan Srinivasan <svaidy@linux.vnet.ibm.com> [2008-12-20 15:32:28]:

> * Andrew Morton <akpm@linux-foundation.org> [2008-12-19 20:44:55]:
>
> > On Sat, 20 Dec 2008 10:06:38 +0530 Vaidyanathan Srinivasan <svaidy@linux.vnet.ibm.com> wrote:
> >
> > > >
> > > > kernel/sched.c: In function 'schedule':
> > > > kernel/sched.c:3679: warning: 'active_balance' may be used uninitialized in this function
> > > >
> > > > This warning is correct - the code is buggy.
> > >
> > > Yes this is my code bug. I did not see the warning in sched.c. Is
> > > there any build option that I need to pass in order to get -Wall
> > > effect?
> >
> > That was just with plain old kbuild: `make allmodconfig;make'.
> >
> > That warning was produced by gcc-4.0.2. If you're using something more
> > recent then gcc has regressed.
>
> This is an interesting problem. I am unable to get that warning in the
> following GCC versions even with a combination of the following
> cmdline options: -Wall -Wextra -Wuninitialized
>
> gcc version 4.1.2 20070502
> gcc version 4.2.3
>
> I will look for older gcc and check this out.

I am able to get the above warning in
gcc version 3.4.6 (Debian 3.4.6-9)
with default kbuild, no additional params.

Did not get the warning in
gcc version 4.1.3 20080623

Hence there has been some change in GCC that prevented the
uninitialized warning.

--Vaidy


\
 
 \ /
  Last update: 2008-12-20 11:37    [W:0.066 / U:0.288 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site