Messages in this thread Patch in this message | | | Date | Wed, 3 Dec 2008 13:50:10 +0900 | From | KAMEZAWA Hiroyuki <> | Subject | [PATCH 2/21] memcg-check-group-leader-fix.patch |
| |
Remove unnecessary codes (...fragments of not-implemented functionalilty...)
Changelog: - removed all unused fragments. - added comment.
Reported-by: Nikanth Karthikesan <knikanth@suse.de> Signed-off-by: Nikanth Karthikesan <knikanth@suse.de> Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Index: mmotm-2.6.28-Nov30/mm/memcontrol.c =================================================================== --- mmotm-2.6.28-Nov30.orig/mm/memcontrol.c +++ mmotm-2.6.28-Nov30/mm/memcontrol.c @@ -2008,25 +2008,10 @@ static void mem_cgroup_move_task(struct struct cgroup *old_cont, struct task_struct *p) { - struct mm_struct *mm; - struct mem_cgroup *mem, *old_mem; - - mm = get_task_mm(p); - if (mm == NULL) - return; - - mem = mem_cgroup_from_cont(cont); - old_mem = mem_cgroup_from_cont(old_cont); - /* - * Only thread group leaders are allowed to migrate, the mm_struct is - * in effect owned by the leader + * FIXME: It's better to move charges of this process from old + * memcg to new memcg. But it's just on TODO-List now. */ - if (!thread_group_leader(p)) - goto out; - -out: - mmput(mm); } struct cgroup_subsys mem_cgroup_subsys = {
| |