lkml.org 
[lkml]   [2008]   [Dec]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 3/5] ring-buffer: read page interface
Date
On Wednesday 03 December 2008 08:06:54 Andrew Morton wrote:
> Steven Rostedt <rostedt@goodmis.org> wrote:
> > + if (!local_read(&cpu_buffer->reader_page->page->commit))
>
> Rusty (I think it was Rusty) has convincingly argued that local_t is
> irredeemably busted. I forget the details?

That was probably Christoph Lameter. The x86 implementation needs some love,
but the API seems reasonable.

On x86-32, the cpu_local_inc should be (as intended) turned into one insn.
That would be possible on 64 bit once we get zero-based percpu (as will World
Peace).

Cheers,
Rusty.


\
 
 \ /
  Last update: 2008-12-03 00:11    [W:0.042 / U:0.204 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site