lkml.org 
[lkml]   [2008]   [Dec]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[patch 4/8] SDHCI: Add quirk for controller with no end-of-busy IRQ
    The Samsung SDHCI controller block seems to fail to generate an
    INT_DATA_END after the transfer has completed and the bus busy
    state finished.

    Changes in e809517f6fa5803a5a1cd56026f0e2190fc13d5c to use the
    new busy method are the cause of the behaviour change.

    Signed-off-by: Ben Dooks <ben-linux@fluff.org>

    Index: linux.git/drivers/mmc/host/sdhci.c
    ===================================================================
    --- linux.git.orig/drivers/mmc/host/sdhci.c 2008-12-01 19:31:15.000000000 +0000
    +++ linux.git/drivers/mmc/host/sdhci.c 2008-12-01 19:43:30.000000000 +0000
    @@ -1294,8 +1294,11 @@ static void sdhci_cmd_irq(struct sdhci_h
    if (host->cmd->data)
    DBG("Cannot wait for busy signal when also "
    "doing a data transfer");
    - else
    + else if (!(host->quirks & SDHCI_QUIRK_NO_BUSY_IRQ))
    return;
    +
    + /* The controller does not support the end-of-busy IRQ,
    + * fall through and take the SDHCI_INT_RESPONSE */
    }

    if (intmask & SDHCI_INT_RESPONSE)
    Index: linux.git/drivers/mmc/host/sdhci.h
    ===================================================================
    --- linux.git.orig/drivers/mmc/host/sdhci.h 2008-12-01 19:31:15.000000000 +0000
    +++ linux.git/drivers/mmc/host/sdhci.h 2008-12-01 19:42:27.000000000 +0000
    @@ -210,6 +210,8 @@ struct sdhci_host {
    #define SDHCI_QUIRK_BROKEN_SMALL_PIO (1<<13)
    /* Controller supports high speed but doesn't have the caps bit set */
    #define SDHCI_QUIRK_FORCE_HIGHSPEED (1<<14)
    +/* Controller does not provide transfer-complete interrupt when not busy */
    +#define SDHCI_QUIRK_NO_BUSY_IRQ (1<<15)

    int irq; /* Device IRQ */
    void __iomem * ioaddr; /* Mapped address */
    --
    Ben (ben@fluff.org, http://www.fluff.org/)

    'a smiley only costs 4 bytes'


    \
     
     \ /
      Last update: 2008-12-02 16:43    [W:0.019 / U:2.356 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site