Messages in this thread Patch in this message | | | From | "Duane Griffin" <> | Date | Fri, 19 Dec 2008 22:22:48 +0000 | Subject | Re: [PATCH, v5] 9p: don't print IS_ERR strings |
| |
On Fri, Dec 19, 2008 at 04:07:53PM -0600, Eric Van Hensbergen wrote: > NAK - the print is a debug to mark function entry when debugging is on > -- it is not intended to show only success. If an erroneous s will > cause the print to break then perhaps it should be parameterized, but > the entire print shouldn't be pushed inside the if statement.
If s is an error then I suppose it will BUG when the printk tries to dereference it. So I think a fix is necessary. How about this?
diff --git a/fs/9p/vfs_inode.c b/fs/9p/vfs_inode.c index 8fddfe8..e10c27d 100644 --- a/fs/9p/vfs_inode.c +++ b/fs/9p/vfs_inode.c @@ -1022,7 +1022,9 @@ v9fs_vfs_put_link(struct dentry *dentry, struct nameidata *nd, void *p) { char *s = nd_get_link(nd); - P9_DPRINTK(P9_DEBUG_VFS, " %s %s\n", dentry->d_name.name, s); + P9_DPRINTK(P9_DEBUG_VFS, " %s %s\n", dentry->d_name.name, + IS_ERR(s) ? "<error>" : s); + if (!IS_ERR(s)) __putname(s); } Cheers, Duane.
-- "I never could learn to drink that blood and call it wine" - Bob Dylan
| |