lkml.org 
[lkml]   [2008]   [Dec]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: nbd: clean up error handling
Hi Pavel,

hanks for the patch...

Pavel Machek wrote:
> Uses existing error_out: label instead of hardcoding error action.
>
> Signed-off-by: Pavel Machek <pavel@suse.cz>

> @@ -475,8 +473,7 @@ static void nbd_handle_req(struct nbd_de
> if (nbd_send_req(lo, req) != 0) {
> printk(KERN_ERR "%s: Request send failed\n",
> lo->disk->disk_name);
> - req->errors++;
> - nbd_end_request(req);
> + goto error_out;

This one is not correct. We don't return immediately here.


--
Paul


\
 
 \ /
  Last update: 2008-12-18 20:27    [W:0.236 / U:0.116 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site