Messages in this thread | | | Date | Thu, 18 Dec 2008 14:15:39 -0500 | From | Paul Clements <> | Subject | Re: nbd: clean up error handling |
| |
Hi Pavel,
hanks for the patch...
Pavel Machek wrote: > Uses existing error_out: label instead of hardcoding error action. > > Signed-off-by: Pavel Machek <pavel@suse.cz>
> @@ -475,8 +473,7 @@ static void nbd_handle_req(struct nbd_de > if (nbd_send_req(lo, req) != 0) { > printk(KERN_ERR "%s: Request send failed\n", > lo->disk->disk_name); > - req->errors++; > - nbd_end_request(req); > + goto error_out;
This one is not correct. We don't return immediately here.
-- Paul
| |