Messages in this thread Patch in this message | | | From | Mark McLoughlin <> | Subject | [PATCH 1/3] virtio: teach virtio_has_feature() about transport features | Date | Thu, 18 Dec 2008 17:10:20 +0000 |
| |
Drivers don't add transport features to their table, so we shouldn't check these with virtio_check_driver_offered_feature().
We could perhaps add an ->offered_feature() virtio_config_op, but that perhaps that would be overkill for a consitency check like this.
Signed-off-by: Mark McLoughlin <markmc@redhat.com> --- include/linux/virtio_config.h | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/include/linux/virtio_config.h b/include/linux/virtio_config.h index bf8ec28..e4ba694 100644 --- a/include/linux/virtio_config.h +++ b/include/linux/virtio_config.h @@ -99,7 +99,9 @@ static inline bool virtio_has_feature(const struct virtio_device *vdev, if (__builtin_constant_p(fbit)) BUILD_BUG_ON(fbit >= 32); - virtio_check_driver_offered_feature(vdev, fbit); + if (fbit < VIRTIO_TRANSPORT_F_START) + virtio_check_driver_offered_feature(vdev, fbit); + return test_bit(fbit, vdev->features); } -- 1.6.0.5
| |