lkml.org 
[lkml]   [2008]   [Dec]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V2 4/7] rtc: PCF50633 rtc driver
On Thu, Dec 18, 2008 at 10:03:10AM +0100, Alessandro Zummo wrote:
> On Thu, 18 Dec 2008 11:27:26 +0530
> Balaji Rao <balajirrao@openmoko.org> wrote:
>
> > Changes from V1:
> > - Removed include/linux/mfd/pcf50633/rtc.h and moved defenitions into
> > the source file.
> > - Remove PIE and introduce UIE support. UIE being the one actually
> > supported in the chip.
> >
> > Alessandro, I'll change to the new API for AIE once it appears upstream.
>
> Ok, I guess the driver will not go in tomorrow, so you can wait.
> I'd add it now, while you're at it :)
>

OK! :) So that I can change when it's in -next ?

> > +config RTC_DRV_PCF50633
> > + depends on MFD_PCF50633
> > + tristate "NXP PCF50633 RTC"
> > + help
> > + If you say yes here you get support for the NXP PCF50633 RTC.
>
> a more detailed description please stating which platforms commonly
> have this rtc
>

OK.

> > +static int __devinit pcf50633_rtc_probe(struct platform_device *pdev)
> > +{
> > + struct pcf50633_subdev_pdata *pdata;
> > + struct pcf50633_rtc *rtc;
> > + struct rtc_device *rtc_dev;
> > +
> > + rtc_dev = rtc_device_register("pcf50633-rtc", &pdev->dev,
> > + &pcf50633_rtc_ops, THIS_MODULE);
> > +
> > + if (IS_ERR(rtc_dev))
> > + return PTR_ERR(rtc_dev);
> > +
> > + rtc = kzalloc(sizeof(*rtc), GFP_KERNEL);
> > + if (!rtc) {
> > + dev_err(&pdev->dev, "allocation of pcf50633_rtc failed\n");
> > + rtc_device_unregister(rtc_dev);
> > + return -ENOMEM;
> > + }
>
> once registered, the rtc could be immediately in use. you should first allocate
> and setup your data structures and only then register the device:
>

Oh, yea right. Will fix.

> > +static int __devexit pcf50633_rtc_remove(struct platform_device *pdev)
> > +{
> > + struct pcf50633_rtc *rtc;
> > +
> > + rtc = platform_get_drvdata(pdev);
> > + rtc_device_unregister(rtc->rtc_dev);
> > +
> > + pcf50633_free_irq(rtc->pcf, PCF50633_IRQ_ALARM);
> > + pcf50633_free_irq(rtc->pcf, PCF50633_IRQ_SECOND);
>
> please remove rtc before unregistering
>

Sorry, didn't get you meant.

Thank you for the review.

-Balaji


\
 
 \ /
  Last update: 2008-12-18 16:15    [W:0.069 / U:0.308 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site