[lkml]   [2008]   [Dec]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH] get rid of the last symlink in uml build
    On Wed, Dec 17, 2008 at 09:55:39AM +0100, Sam Ravnborg wrote:

    > > AFAICS, having archprepare depend on user_constants.h and kern_constants.h
    > > would do just fine. Note that we don't care how these two are ordered;
    > > it's asm-offsets.h that can't be created without user_constants.h.
    > Agreed.
    > Previously we had some race issues in the arch Makefile when they used
    > the prepare target and they were workaround in various ways.
    > This was why we introduced archprepare in the first place IIRC.
    > And I also recall that um was starnge but this is all cleaned up now - good.

    FWIW, how do you plan to deal with include/asm once everything gets moved
    to arch/*/include/asm?

    Right now O=... builds create asm-offsets.h in $(objtree)/include/asm; do
    you plan to take it to $(objtree)/arch/$(ARCH)/include/asm?

    Another bloody annoying thing is dangling include2/asm on such builds, along
    with include/asm-x86 created on non-O=.. ones.

    If/when we stop doing that and just put asm-offsets.h into arch/*/include/asm
    we'll need to update the rule for kern_constants.h to
    $(Q)mkdir -p $(dir $@)
    $(Q)echo '#include "../asm/asm-offsets.h"' >$@
    Not a big deal, just something that'll need to be taken care of when we

     \ /
      Last update: 2008-12-17 10:13    [W:0.035 / U:16.820 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site