lkml.org 
[lkml]   [2008]   [Dec]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 7/15] sanitize AUDIT_MQ_SENDRECV
On Wed, 17 Dec 2008 05:12:10 +0000 Al Viro <viro@ftp.linux.org.uk> wrote:

>
> * logging the original value of *msg_prio in mq_timedreceive(2)
> is insane - the argument is write-only (i.e. syscall always
> ignores the original value and only overwrites it).
> * merge __audit_mq_timed{send,receive}
> * don't do copy_from_user() twice
> * don't mess with allocations in auditsc part
> * ... and don't bother checking !audit_enabled and !context in there -
> we'd already checked for audit_dummy_context().
>
> ...
>
> + if (copy_from_user(&ts, u_abs_timeout,
> + sizeof(struct timespec)))

Well that's odd. afacit timespec has different sizes on 32-bit and
64-bit userspace.

But the old audit code did this copy too, and it presumably worked.


\
 
 \ /
  Last update: 2008-12-17 08:59    [W:0.045 / U:1.132 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site