Messages in this thread | | | Date | Wed, 17 Dec 2008 18:40:54 +1100 (EST) | From | James Morris <> | Subject | Re: [PATCH 7/15] sanitize AUDIT_MQ_SENDRECV |
| |
On Wed, 17 Dec 2008, Al Viro wrote:
> > * logging the original value of *msg_prio in mq_timedreceive(2) > is insane - the argument is write-only (i.e. syscall always > ignores the original value and only overwrites it).
I wonder if any existing certifications need to be amended.
> * merge __audit_mq_timed{send,receive} > * don't do copy_from_user() twice > * don't mess with allocations in auditsc part > * ... and don't bother checking !audit_enabled and !context in there - > we'd already checked for audit_dummy_context(). > > Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Reviewed-by: James Morris <jmorris@namei.org>
-- James Morris <jmorris@namei.org>
| |